Merged
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Nic-Ma
reviewed
Mar 1, 2022
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang [email protected]
Fixes #3867 .
Description
This PR fixes the
_set_default_rangeissue in classRandKSpaceSpikeNoise.There are two errors in this function:
np.meandoes not have the argdim(this bug is reported inRandKSpaceSpikeNoisegot an unexpected keyword argument 'dim' #3867 , thanks to @mibaumgartner !)img, ifimgis saved in GPU, error will be raised in the followingself.R.uniformmanipulation step.In addition, this PR adds the test case (none intensity_range) for
RandKSpaceSpikeNoise, and the test case (none k_intensity) forKSpaceSpikeNoise.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.