Skip to content

enhance to use spatial_shape ResampleToMatch#3847

Merged
wyli merged 7 commits intoProject-MONAI:devfrom
wyli:enhance-shape-property-resmaple-to-match
Mar 1, 2022
Merged

enhance to use spatial_shape ResampleToMatch#3847
wyli merged 7 commits intoProject-MONAI:devfrom
wyli:enhance-shape-property-resmaple-to-match

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Feb 23, 2022

Signed-off-by: Wenqi Li [email protected]

follow up of #3833

Description

spatial_shape is a more reliable attribute from the readers for resampletomatch

header["spatial_shape"] = self._get_spatial_shape(i)

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested a review from rijobro February 23, 2022 11:46
@wyli wyli changed the title enhance to use spatial_size ResampleToMatch enhance to use spatial_shape ResampleToMatch Feb 23, 2022
@wyli wyli force-pushed the enhance-shape-property-resmaple-to-match branch from 3ec7ac8 to 196a070 Compare February 23, 2022 11:48
@wyli wyli force-pushed the enhance-shape-property-resmaple-to-match branch from 196a070 to 7db4144 Compare February 23, 2022 11:48
Signed-off-by: Wenqi Li <[email protected]>
wyli added 2 commits February 23, 2022 15:31
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@rijobro rijobro mentioned this pull request Feb 24, 2022
2 tasks
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Mar 1, 2022

/black

@wyli wyli enabled auto-merge (squash) March 1, 2022 08:49
@wyli wyli merged commit 9737fb9 into Project-MONAI:dev Mar 1, 2022
@wyli wyli deleted the enhance-shape-property-resmaple-to-match branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants