Fix reshape in ViTAutoEnc#3841
Merged
wyli merged 4 commits intoProject-MONAI:devfrom Feb 22, 2022
razorx89:fix-vitautoenc-shape
Merged
Fix reshape in ViTAutoEnc#3841wyli merged 4 commits intoProject-MONAI:devfrom razorx89:fix-vitautoenc-shape
wyli merged 4 commits intoProject-MONAI:devfrom
razorx89:fix-vitautoenc-shape
Conversation
Signed-off-by: Sven Koitka <[email protected]>
Signed-off-by: Sven Koitka <[email protected]>
Signed-off-by: Sven Koitka <[email protected]>
wyli
approved these changes
Feb 22, 2022
Contributor
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of ViTAutoEnc always expects a cubic volume shape and does not reshape the output sequence of ViT based on the patch and volume size. Thus for non-cubic volumes, this results in an exception because the reshape operation fails.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.