Skip to content

3830 Fix margin size in CropForeground transform#3837

Merged
Nic-Ma merged 10 commits intoProject-MONAI:devfrom
Nic-Ma:3830-fix-cropforground
Feb 22, 2022
Merged

3830 Fix margin size in CropForeground transform#3837
Nic-Ma merged 10 commits intoProject-MONAI:devfrom
Nic-Ma:3830-fix-cropforground

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Feb 22, 2022

Fixes #3830 .

Description

This PR fixed the margin size issue in CropForeground transform and added flag and unit tests.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma mentioned this pull request Feb 22, 2022
Closed
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 22, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 22, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli February 22, 2022 04:58
wyli
wyli reviewed Feb 22, 2022
View reviewed changes
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 22, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 22, 2022

/build

1 similar comment
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 22, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 22, 2022

Updated arg name to allow_smaller to be consistent with:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/croppad/array.py#L874

Thanks.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 22, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 22, 2022

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) February 22, 2022 12:47
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Feb 22, 2022

/build

@Nic-Ma Nic-Ma merged commit e570c3b into Project-MONAI:dev Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CropForeground pads asymmetric

2 participants

@Nic-Ma @wyli