3708 - refactor testing data fetching and migrate to release assets#3814
Merged
wyli merged 2 commits intoProject-MONAI:devfrom Feb 18, 2022
Merged
3708 - refactor testing data fetching and migrate to release assets#3814wyli merged 2 commits intoProject-MONAI:devfrom
wyli merged 2 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Wenqi Li <[email protected]>
wyli
added this to the
Data hosting for MONAI models (from Google Drive to GitHub) [P1] milestone
Contributor
Author
|
/build |
Nic-Ma
approved these changes
Feb 18, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the quick update.
Looks good to me.
pxLi
approved these changes
Feb 18, 2022
Contributor
pxLi
left a comment
pxLi
left a comment
There was a problem hiding this comment.
LGTM.
nit: data_config keys length and name check as the fixed format, but not a big deal :)
Contributor
Author
|
/build |
Contributor
Author
Thanks @pxLi as you can see all the ci jobs will download and cache these testing data to the "testing_data" folder. Would be great to have a shared space for them at runtime to avoid repeated downloading... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #3708
Description
testing data are now also available here
this PR unified the config file to organise the testing data
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.