Skip to content

3799 change raise error to warnings for some metrics#3804

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
yiheng-wang-nv:3799-soft-metric
Feb 14, 2022
Merged

3799 change raise error to warnings for some metrics#3804
wyli merged 2 commits intoProject-MONAI:devfrom
yiheng-wang-nv:3799-soft-metric

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

Signed-off-by: Yiheng Wang [email protected]

Fixes #3799 .

Description

In this PR, the hard requirements for y (be binarized tensor) are changed to warnings for SurfaceDistanceMetric, HausdorffDistanceMetric and DiceMetric. These may be helpful for some use cases.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Feb 14, 2022

/build

@wyli wyli enabled auto-merge (squash) February 14, 2022 13:39
@wyli wyli merged commit b39e7fa into Project-MONAI:dev Feb 14, 2022
@yiheng-wang-nv yiheng-wang-nv deleted the 3799-soft-metric branch February 14, 2022 14:31
wyli pushed a commit to wyli/MONAI that referenced this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Soft Dice Metric request

2 participants