Skip to content

3795 Add ensure_channel_first to LoadImage#3796

Merged
wyli merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:3795-ensure-channel-first
Feb 12, 2022
Merged

3795 Add ensure_channel_first to LoadImage#3796
wyli merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:3795-ensure-channel-first

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Feb 12, 2022

Fixes #3795 .

Description

This PR added option ensure_channel_first to LoadImage transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 12, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 12, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 12, 2022

/build

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is nonbreaking for loadimage, looks good to me.

@wyli wyli merged commit 2d35301 into Project-MONAI:dev Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ensure_channel_first option to LoadImaged

3 participants