Skip to content

3791 orientation xform warning spatial dims#3792

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
wyli:3791-orientation-warning
Feb 13, 2022
Merged

3791 orientation xform warning spatial dims#3792
wyli merged 4 commits intoProject-MONAI:devfrom
wyli:3791-orientation-warning

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Feb 12, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #3791

Description

adds a warning message when reorienting if needed

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested a review from Nic-Ma February 12, 2022 10:29
@wyli wyli requested a review from Nic-Ma February 13, 2022 01:53
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Feb 13, 2022

/build

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
Put minor comment inline, others look good to me.

Thanks.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3791-orientation-warning branch from 6affd4c to cef6a71 Compare February 13, 2022 20:30
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Feb 13, 2022

/build

@wyli wyli enabled auto-merge (squash) February 13, 2022 20:31
@wyli wyli merged commit 42603b3 into Project-MONAI:dev Feb 13, 2022
@wyli wyli deleted the 3791-orientation-warning branch February 13, 2022 21:06
wyli added a commit to wyli/MONAI that referenced this pull request Feb 16, 2022
* fixes Project-MONAI#3791

Signed-off-by: Wenqi Li <[email protected]>

* update docstring of invertd, update based on comments

Signed-off-by: Wenqi Li <[email protected]>

* fixes typo

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Orientation transform warning of incompatible spatial dims

2 participants