3769 Enhance logger logic of StatsHandler and DataStats#3774
Merged
wyli merged 17 commits intoProject-MONAI:devfrom Feb 8, 2022
Merged
3769 Enhance logger logic of StatsHandler and DataStats#3774wyli merged 17 commits intoProject-MONAI:devfrom
wyli merged 17 commits intoProject-MONAI:devfrom
Conversation
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
1 similar comment
Contributor
Author
|
/build |
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/build |
wyli
reviewed
Feb 7, 2022
Contributor
Author
|
/build |
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
ericspod
reviewed
Feb 7, 2022
ericspod
reviewed
Feb 7, 2022
ericspod
reviewed
Feb 7, 2022
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
wyli
approved these changes
Feb 7, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks, this simplifies the logger handling, would be great to update the tutorials for the same refactoring.
ericspod
approved these changes
Feb 7, 2022
Contributor
Author
|
/integration-test |
Contributor
Author
|
Thanks for your review. Thanks. |
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
2 similar comments
Contributor
Author
|
/build |
Contributor
|
/build |
Contributor
|
/build |
wyli
pushed a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] enhance logger Signed-off-by: Nic Ma <[email protected]> * [DLMED] add more tests Signed-off-by: Nic Ma <[email protected]> * [DLMED] update doc Signed-off-by: Nic Ma <[email protected]> * [DLMED] fix packaging test Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> * [DLMED] remove typo Signed-off-by: Nic Ma <[email protected]> * [DLMED] totally update according to comments Signed-off-by: Nic Ma <[email protected]> * [DLMED] update handlers Signed-off-by: Nic Ma <[email protected]> * [DLMED] update tutorial link Signed-off-by: Nic Ma <[email protected]>
wyli
pushed a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] enhance logger Signed-off-by: Nic Ma <[email protected]> * [DLMED] add more tests Signed-off-by: Nic Ma <[email protected]> * [DLMED] update doc Signed-off-by: Nic Ma <[email protected]> * [DLMED] fix packaging test Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> * [DLMED] remove typo Signed-off-by: Nic Ma <[email protected]> * [DLMED] totally update according to comments Signed-off-by: Nic Ma <[email protected]> * [DLMED] update handlers Signed-off-by: Nic Ma <[email protected]> * [DLMED] update tutorial link Signed-off-by: Nic Ma <[email protected]>
wyli
pushed a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] enhance logger Signed-off-by: Nic Ma <[email protected]> * [DLMED] add more tests Signed-off-by: Nic Ma <[email protected]> * [DLMED] update doc Signed-off-by: Nic Ma <[email protected]> * [DLMED] fix packaging test Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> * [DLMED] remove typo Signed-off-by: Nic Ma <[email protected]> * [DLMED] totally update according to comments Signed-off-by: Nic Ma <[email protected]> * [DLMED] update handlers Signed-off-by: Nic Ma <[email protected]> * [DLMED] update tutorial link Signed-off-by: Nic Ma <[email protected]>
wyli
pushed a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] enhance logger Signed-off-by: Nic Ma <[email protected]> * [DLMED] add more tests Signed-off-by: Nic Ma <[email protected]> * [DLMED] update doc Signed-off-by: Nic Ma <[email protected]> * [DLMED] fix packaging test Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> * [DLMED] remove typo Signed-off-by: Nic Ma <[email protected]> * [DLMED] totally update according to comments Signed-off-by: Nic Ma <[email protected]> * [DLMED] update handlers Signed-off-by: Nic Ma <[email protected]> * [DLMED] update tutorial link Signed-off-by: Nic Ma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3769 .
Description
Thanks for the feedback in #3769 , this PR mainly:
StatsHandlerifname=Noneandaddtional_handler, in the current code it will attach the additional handler to the system root logger.DataStatsif base log level is already INFO.engine.loggerand may not be able to print.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.