3765 Enhance create_multigpu_supervised_XXX for distributed#3768
Merged
Nic-Ma merged 8 commits intoProject-MONAI:devfrom Feb 4, 2022
Merged
3765 Enhance create_multigpu_supervised_XXX for distributed#3768Nic-Ma merged 8 commits intoProject-MONAI:devfrom
create_multigpu_supervised_XXX for distributed#3768Nic-Ma merged 8 commits intoProject-MONAI:devfrom
Conversation
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
Nic-Ma
changed the title
create_multigpu_supervised_XXX for distributed
Contributor
Author
|
/black |
Contributor
Author
|
/build |
wyli
reviewed
Feb 4, 2022
wyli
approved these changes
Feb 4, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
wyli
pushed a commit
to wyli/MONAI
that referenced
this pull request
Feb 5, 2022
…t-MONAI#3768) * [DLMED] add check for devices Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]>
wyli
added a commit
that referenced
this pull request
Feb 7, 2022
* temp spatial_resample Signed-off-by: Wenqi Li <[email protected]> * fixes resampling Signed-off-by: Wenqi Li <[email protected]> * fixes precisions Signed-off-by: Wenqi Li <[email protected]> * update dict version Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * adds docs Signed-off-by: Wenqi Li <[email protected]> * copy grid for resampling Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * remove normalize coordinates Signed-off-by: Wenqi Li <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> * try to fix #3621 (#3673) Signed-off-by: Wenqi Li <[email protected]> * fixes typing Signed-off-by: Wenqi Li <[email protected]> * fixes grid_sample, interpolate URLs Signed-off-by: Wenqi Li <[email protected]> * simplify norm_coords Signed-off-by: Wenqi Li <[email protected]> * update docstring Signed-off-by: Wenqi Li <[email protected]> * update moveaxis Signed-off-by: Wenqi Li <[email protected]> * spatial sample tests Signed-off-by: Wenqi Li <[email protected]> * additional tests spatial resample Signed-off-by: Wenqi Li <[email protected]> * test invert saptial resample Signed-off-by: Wenqi Li <[email protected]> * adds a base writer and an itk writer Signed-off-by: Wenqi Li <[email protected]> * update docstrings Signed-off-by: Wenqi Li <[email protected]> * remove return self Signed-off-by: Wenqi Li <[email protected]> * adds reorient_spatial_axes Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * sync 3701 Signed-off-by: Wenqi Li <[email protected]> * try to fix #3766 Signed-off-by: Wenqi Li <[email protected]> * revise docstring to be concise Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * 3765 Enhance `create_multigpu_supervised_XXX` for distributed (#3768) * [DLMED] add check for devices Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> * update to support dynamic spatial_size Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
Feb 8, 2022
* temp spatial_resample Signed-off-by: Wenqi Li <[email protected]> * fixes resampling Signed-off-by: Wenqi Li <[email protected]> * fixes precisions Signed-off-by: Wenqi Li <[email protected]> * update dict version Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * adds docs Signed-off-by: Wenqi Li <[email protected]> * copy grid for resampling Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * remove normalize coordinates Signed-off-by: Wenqi Li <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> * try to fix #3621 (#3673) Signed-off-by: Wenqi Li <[email protected]> * fixes typing Signed-off-by: Wenqi Li <[email protected]> * fixes grid_sample, interpolate URLs Signed-off-by: Wenqi Li <[email protected]> * simplify norm_coords Signed-off-by: Wenqi Li <[email protected]> * update docstring Signed-off-by: Wenqi Li <[email protected]> * update moveaxis Signed-off-by: Wenqi Li <[email protected]> * spatial sample tests Signed-off-by: Wenqi Li <[email protected]> * additional tests spatial resample Signed-off-by: Wenqi Li <[email protected]> * test invert saptial resample Signed-off-by: Wenqi Li <[email protected]> * adds a base writer and an itk writer Signed-off-by: Wenqi Li <[email protected]> * update docstrings Signed-off-by: Wenqi Li <[email protected]> * remove return self Signed-off-by: Wenqi Li <[email protected]> * adds reorient_spatial_axes Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * sync 3701 Signed-off-by: Wenqi Li <[email protected]> * try to fix #3766 Signed-off-by: Wenqi Li <[email protected]> * revise docstring to be concise Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * 3765 Enhance `create_multigpu_supervised_XXX` for distributed (#3768) * [DLMED] add check for devices Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> * update to support dynamic spatial_size Signed-off-by: Wenqi Li <[email protected]> * adds nibabel pil writers Signed-off-by: Wenqi Li <[email protected]> * remove unused ignore Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>
wyli
pushed a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] add check for devices Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]>
wyli
pushed a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] add check for devices Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]>
wyli
pushed a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] add check for devices Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]>
wyli
pushed a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] add check for devices Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3765 .
Description
This PR enhanced
create_multigpu_supervised_trainerfor devices whendistributed=True, and added distributed tests.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.