Skip to content

3747 Enhance errors and docs according to Youtube feedback#3759

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:3747-enhance-errors
Feb 3, 2022
Merged

3747 Enhance errors and docs according to Youtube feedback#3759
wyli merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:3747-enhance-errors

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Feb 2, 2022

Fixes part of #3747 .

Description

This PR enhanced errors and docs according to the feedback in Youtube video: https://www.youtube.com/watch?v=M3ZWfamWrBM.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma Nic-Ma changed the title [WIP] 3747 Enhance errors and docs according to Youtube feedback 3747 Enhance errors and docs according to Youtube feedback Feb 2, 2022
@Nic-Ma Nic-Ma marked this pull request as ready for review February 2, 2022 03:21
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli February 2, 2022 03:22
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 2, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 2, 2022

/build

2 similar comments
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 2, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 2, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 3, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 3, 2022

/build

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Feb 3, 2022

/build

@wyli wyli enabled auto-merge (squash) February 3, 2022 08:50
@wyli wyli merged commit 6c75550 into Project-MONAI:dev Feb 3, 2022
wyli pushed a commit that referenced this pull request Feb 9, 2022
* [DLMED] enhance missing key error

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update doc

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>
wyli pushed a commit that referenced this pull request Feb 9, 2022
* [DLMED] enhance missing key error

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update doc

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>
wyli pushed a commit that referenced this pull request Feb 9, 2022
* [DLMED] enhance missing key error

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update doc

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>
wyli pushed a commit that referenced this pull request Feb 9, 2022
* [DLMED] enhance missing key error

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update doc

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants