Skip to content

3750 skip setuptool 60.6#3751

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
wyli:3750-setuptool-issue
Jan 31, 2022
Merged

3750 skip setuptool 60.6#3751
wyli merged 4 commits intoProject-MONAI:devfrom
wyli:3750-setuptool-issue

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jan 31, 2022

Signed-off-by: Wenqi Li [email protected]

fix/workaround for a few ci/cd issues
Workaround #3750
Workaround #3752
Fixes #3757

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits January 31, 2022 12:28
Signed-off-by: Wenqi Li <[email protected]>
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workaround looks good to me.
I remember we had a discussion about dropping setuptool, what's the conclusion? Seems it's not very stable..

Thanks.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli marked this pull request as ready for review January 31, 2022 17:33
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jan 31, 2022

/build

@wyli wyli enabled auto-merge (squash) January 31, 2022 17:34
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jan 31, 2022

/build

@wyli wyli force-pushed the 3750-setuptool-issue branch from 57cb6b2 to 2b093b7 Compare January 31, 2022 19:13
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jan 31, 2022

/build

2 similar comments
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jan 31, 2022

/build

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jan 31, 2022

/build

@wyli wyli merged commit ba9cd45 into Project-MONAI:dev Jan 31, 2022
@wyli wyli deleted the 3750-setuptool-issue branch January 31, 2022 23:03
wyli added a commit that referenced this pull request Feb 9, 2022
* ignore 60.6.0

Signed-off-by: Wenqi Li <[email protected]>

* workaround #3752

Signed-off-by: Wenqi Li <[email protected]>

* fixes windows issue

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows download url

2 participants