Skip to content

3734 Enhance CacheDataset to avoid duplicated cache#3739

Merged
Nic-Ma merged 16 commits intoProject-MONAI:devfrom
Nic-Ma:3734-add-hashid-cache
Feb 1, 2022
Merged

3734 Enhance CacheDataset to avoid duplicated cache#3739
Nic-Ma merged 16 commits intoProject-MONAI:devfrom
Nic-Ma:3734-add-hashid-cache

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jan 29, 2022

Fixes #3734 .

Description

This PR enhancedCacheDataset to avoid caching duplicated content for the augmented dataset.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 29, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 29, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli January 29, 2022 08:38
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 29, 2022

/build

Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 29, 2022

/build

@Nic-Ma Nic-Ma force-pushed the 3734-add-hashid-cache branch from e1b0ede to b57a755 Compare January 30, 2022 04:02
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 30, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 30, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 30, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 30, 2022

Mark: autoformat is updated, so /black introduced some extra change in this PR.

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 30, 2022

Sure, I'll separate the style changes into another style PR...

@Nic-Ma Nic-Ma changed the title 3734 Add HashCacheDataset to avoid duplicated cache 3734 Enhance CacheDataset to avoid duplicated cache Jan 30, 2022
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 30, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 31, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 31, 2022

/build

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 31, 2022

/build

2 similar comments
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 1, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 1, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 1, 2022

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) February 1, 2022 13:19
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 1, 2022

/build

@Nic-Ma Nic-Ma merged commit 6f16823 into Project-MONAI:dev Feb 1, 2022
wyli added a commit that referenced this pull request Feb 9, 2022
* [DLMED] add HashCacheDataset

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add more test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] skip min test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix flake8

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: monai-bot <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request Feb 9, 2022
* [DLMED] add HashCacheDataset

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add more test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] skip min test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix flake8

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: monai-bot <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request Feb 9, 2022
* [DLMED] add HashCacheDataset

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add more test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] skip min test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix flake8

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: monai-bot <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request Feb 9, 2022
* [DLMED] add HashCacheDataset

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add more test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] skip min test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix flake8

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: monai-bot <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid duplicated cache content in CacheDataset

3 participants