Skip to content

pip mypy#3722

Merged
wyli merged 1 commit intoProject-MONAI:devfrom
rijobro:pip_mypy
Jan 27, 2022
Merged

pip mypy#3722
wyli merged 1 commit intoProject-MONAI:devfrom
rijobro:pip_mypy

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Jan 27, 2022

I've found conda mypy to be very slow (~8min) compared to pip (~1min).

Hence, I propose to only use the pip version, even when installing via conda.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from Nic-Ma, ericspod and wyli January 27, 2022 13:33
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 27, 2022

/build

@wyli wyli enabled auto-merge (squash) January 27, 2022 13:53
@wyli wyli merged commit 4aa3596 into Project-MONAI:dev Jan 27, 2022
@rijobro rijobro deleted the pip_mypy branch May 19, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants