fixes grid_sample, interpolate URLs#3712
Merged
wyli merged 3 commits intoProject-MONAI:devfrom Jan 26, 2022
Merged
Conversation
Nic-Ma
approved these changes
Jan 26, 2022
Contributor
There was a problem hiding this comment.
Hi @wyli ,
Looks good to me.
Seems PyTorch team re-organized their web pages recently, could you please help also double-check and update other https://pytorch.org/docs/... links in our codebase with this PR?
Or maybe I think we can make some mapping table in the MONAI storage repo, then maintain all the links in it? Like the ticket: #3708.
Thanks.
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* fixes grid_sample, interpolate URLs Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* fixes grid_sample, interpolate URLs Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* fixes grid_sample, interpolate URLs Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Description
the current grid_sample and interpolate urls don't work
(is there a better way to maintain these external links?
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.