Skip to content

add benchmarking warp against python itk#3692

Merged
wyli merged 12 commits intoProject-MONAI:devfrom
kate-sann5100:3691-benchmark-warp
Jan 24, 2022
Merged

add benchmarking warp against python itk#3692
wyli merged 12 commits intoProject-MONAI:devfrom
kate-sann5100:3691-benchmark-warp

Conversation

@kate-sann5100
Copy link
Copy Markdown
Collaborator

@kate-sann5100 kate-sann5100 commented Jan 20, 2022

Signed-off-by: kate-sann5100 [email protected]

Fixes #3691.

Description

Add python-itk-related quantitative results to unit-testing.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@kate-sann5100 kate-sann5100 linked an issue Jan 20, 2022 that may be closed by this pull request
@kate-sann5100
Copy link
Copy Markdown
Collaborator Author

/black

@kate-sann5100
Copy link
Copy Markdown
Collaborator Author

kate-sann5100 commented Jan 21, 2022

/black

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 24, 2022

/build

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 24, 2022

/build

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr compares the interpolation and padding patterns against itk python. itk ResampleImageFilter is preferred over WarpImageFilter we should update when the official examples are upgraded. (InsightSoftwareConsortium/ITK#809)

@wyli wyli enabled auto-merge (squash) January 24, 2022 11:29
@wyli wyli merged commit 3907cb4 into Project-MONAI:dev Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Registration benchmarking - Warp

3 participants