remove tensor-array conversion in Orientation#3687
Merged
wyli merged 9 commits intoProject-MONAI:devfrom Jan 21, 2022
Merged
Conversation
Signed-off-by: Wenqi Li <[email protected]>
wyli
changed the title
Orientation
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
rijobro
reviewed
Jan 20, 2022
rijobro
reviewed
Jan 20, 2022
Contributor
rijobro
left a comment
rijobro
left a comment
There was a problem hiding this comment.
looks good to me, thanks!
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/integration-test |
Nic-Ma
approved these changes
Jan 21, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me except for minor comment.
Thanks.
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
Contributor
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* remove tensor-array convertions Signed-off-by: Wenqi Li <[email protected]> * update backend Signed-off-by: Wenqi Li <[email protected]> * update tests, remove meshgrid warnings Signed-off-by: Wenqi Li <[email protected]> * fixes typing issue Signed-off-by: Wenqi Li <[email protected]> * fixes import Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* remove tensor-array convertions Signed-off-by: Wenqi Li <[email protected]> * update backend Signed-off-by: Wenqi Li <[email protected]> * update tests, remove meshgrid warnings Signed-off-by: Wenqi Li <[email protected]> * fixes typing issue Signed-off-by: Wenqi Li <[email protected]> * fixes import Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* remove tensor-array convertions Signed-off-by: Wenqi Li <[email protected]> * update backend Signed-off-by: Wenqi Li <[email protected]> * update tests, remove meshgrid warnings Signed-off-by: Wenqi Li <[email protected]> * fixes typing issue Signed-off-by: Wenqi Li <[email protected]> * fixes import Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Description
non-breaking update to avoid tensor <-> ndarray conversion for the input image in
OrientationtransformStatus
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.