Skip to content

Update make_nifti#3682

Merged
rijobro merged 4 commits intoProject-MONAI:devfrom
rijobro:make_nifti_update
Jan 19, 2022
Merged

Update make_nifti#3682
rijobro merged 4 commits intoProject-MONAI:devfrom
rijobro:make_nifti_update

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Jan 19, 2022

Description

Allow test image creation to save to different folders and with different file names.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@rijobro rijobro requested review from Nic-Ma and wyli January 19, 2022 16:09
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please add the unit tests to

exclude_cases = [ # these cases use external dependencies
or add a decorator for skipif nibabel is not installed

@rijobro rijobro enabled auto-merge (squash) January 19, 2022 17:27
@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Jan 19, 2022

done, thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 19, 2022

/black

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 19, 2022

/build

@rijobro rijobro merged commit ab14b8b into Project-MONAI:dev Jan 19, 2022
@rijobro rijobro deleted the make_nifti_update branch January 20, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants