Skip to content

3670 Fix channel_dim in ITKReader and add in it NibabelReader#3678

Merged
wyli merged 9 commits intoProject-MONAI:devfrom
Nic-Ma:3670-channel-dim-nibabel
Jan 19, 2022
Merged

3670 Fix channel_dim in ITKReader and add in it NibabelReader#3678
wyli merged 9 commits intoProject-MONAI:devfrom
Nic-Ma:3670-channel-dim-nibabel

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jan 19, 2022 •
edited
Loading

Fixes #3670 .

Description

This PR fixed channel_dim in ITKReader and added in it NibabelReader.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

This was referenced Jan 19, 2022
Closed
Closed
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 19, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 19, 2022

/build

@Nic-Ma Nic-Ma changed the title [WIP] 3670 Fix channel_dim in ITKReader and add in it NibabelReader 3670 Fix channel_dim in ITKReader and add in it NibabelReader Jan 19, 2022
@Nic-Ma Nic-Ma marked this pull request as ready for review January 19, 2022 14:58
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli January 19, 2022 14:58
wyli
wyli approved these changes Jan 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me apart from the extra test_load_imaged change

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 19, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 19, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 19, 2022

/integration-test

@wyli wyli enabled auto-merge (squash) January 19, 2022 15:36
@wyli wyli merged commit 2500edd into Project-MONAI:dev Jan 19, 2022
wyli pushed a commit that referenced this pull request Jan 21, 2022
@Nic-Ma @wyli
3670 Fix channel_dim in ITKReader and add in it NibabelReader (#3678)
0e9f969 
* [DLMED] fix channel_dim issue in ITKReader, add it in NibabelReader

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] restore LoadImaged test

Signed-off-by: Nic Ma <[email protected]>
wyli pushed a commit that referenced this pull request Jan 21, 2022
@Nic-Ma @wyli
3670 Fix channel_dim in ITKReader and add in it NibabelReader (#3678)
fe757be 
* [DLMED] fix channel_dim issue in ITKReader, add it in NibabelReader

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] restore LoadImaged test

Signed-off-by: Nic Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nibabel reader need to support channel first data

2 participants

@Nic-Ma @wyli