Skip to content

3672 Change AUC error to warning#3675

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:3672-change-auc-warning
Jan 18, 2022
Merged

3672 Change AUC error to warning#3675
wyli merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:3672-change-auc-warning

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jan 18, 2022

Fixes #3672 .

Description

This PR changed the AUC error for all 0 or all 1 case to warning, according to user and QA feedback.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 18, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 18, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli January 18, 2022 15:22
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) January 18, 2022 15:35
@wyli wyli merged commit c327cfa into Project-MONAI:dev Jan 18, 2022
wyli pushed a commit that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change exception to warning in AUC metric

2 participants