3621 fixes `tests/test_handler_metrics_saver_dist.py` by wyli · Pull Request #3673 · Project-MONAI/MONAI

wyli · 2022-01-18T11:53:48Z

Signed-off-by: Wenqi Li [email protected]

Fixes #3621

Description

adds a barrier to sync the processes

Status

Ready

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
In-line docstrings updated.
Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>

Nic-Ma · 2022-01-20T14:11:53Z

Hi @wyli ,

If barrier() works for this issue, could you please help add it to the DistCall test utility as @vfdev-5 suggested: #3641 (comment)
And I would suggest to change the get_rank() logic back to the original direct call.
What do you think?

Thanks in advance.

wyli · 2022-01-24T14:55:52Z

/build

wyli · 2022-01-25T10:13:09Z

I think this is good given the repeated tests are ok. I don't think the utility should be updated at the moment, unless we see different further issues... @Nic-Ma

Nic-Ma

Sure, looks good to me.

Thanks.

wyli · 2022-01-25T10:16:19Z

/build

Signed-off-by: Wenqi Li <[email protected]>

* temp spatial_resample Signed-off-by: Wenqi Li <[email protected]> * fixes resampling Signed-off-by: Wenqi Li <[email protected]> * fixes precisions Signed-off-by: Wenqi Li <[email protected]> * update dict version Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * adds docs Signed-off-by: Wenqi Li <[email protected]> * copy grid for resampling Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * remove normalize coordinates Signed-off-by: Wenqi Li <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> * try to fix #3621 (#3673) Signed-off-by: Wenqi Li <[email protected]> * fixes typing Signed-off-by: Wenqi Li <[email protected]> * fixes grid_sample, interpolate URLs Signed-off-by: Wenqi Li <[email protected]> * simplify norm_coords Signed-off-by: Wenqi Li <[email protected]> * update docstring Signed-off-by: Wenqi Li <[email protected]> * update moveaxis Signed-off-by: Wenqi Li <[email protected]> * spatial sample tests Signed-off-by: Wenqi Li <[email protected]> * additional tests spatial resample Signed-off-by: Wenqi Li <[email protected]> * test invert saptial resample Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * rtol assert close Signed-off-by: Wenqi Li <[email protected]> * fixes TF32 tests Signed-off-by: Wenqi Li <[email protected]> * smaller tests Signed-off-by: Wenqi Li <[email protected]> * skip when quick testing Signed-off-by: Wenqi Li <[email protected]> * comp tensor and ndarray Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * fixes tests Signed-off-by: Wenqi Li <[email protected]> * try to use torch.solve Signed-off-by: Wenqi Li <[email protected]> * Revert "fixes tests" This reverts commit e532490. Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * fixes test_affined Signed-off-by: Wenqi Li <[email protected]> * default to float32 rotate/randrotate Signed-off-by: Wenqi Li <[email protected]> * workaround for #3752 Signed-off-by: Wenqi Li <[email protected]> * default to float32 rotate/randrotate Signed-off-by: Wenqi Li <[email protected]> * temp test Signed-off-by: Wenqi Li <[email protected]> * update docstring Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: monai-bot <[email protected]>

* temp spatial_resample Signed-off-by: Wenqi Li <[email protected]> * fixes resampling Signed-off-by: Wenqi Li <[email protected]> * fixes precisions Signed-off-by: Wenqi Li <[email protected]> * update dict version Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * adds docs Signed-off-by: Wenqi Li <[email protected]> * copy grid for resampling Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * remove normalize coordinates Signed-off-by: Wenqi Li <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> * try to fix #3621 (#3673) Signed-off-by: Wenqi Li <[email protected]> * fixes typing Signed-off-by: Wenqi Li <[email protected]> * fixes grid_sample, interpolate URLs Signed-off-by: Wenqi Li <[email protected]> * simplify norm_coords Signed-off-by: Wenqi Li <[email protected]> * update docstring Signed-off-by: Wenqi Li <[email protected]> * update moveaxis Signed-off-by: Wenqi Li <[email protected]> * spatial sample tests Signed-off-by: Wenqi Li <[email protected]> * additional tests spatial resample Signed-off-by: Wenqi Li <[email protected]> * test invert saptial resample Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * rtol assert close Signed-off-by: Wenqi Li <[email protected]> * fixes TF32 tests Signed-off-by: Wenqi Li <[email protected]> * smaller tests Signed-off-by: Wenqi Li <[email protected]> * skip when quick testing Signed-off-by: Wenqi Li <[email protected]> * comp tensor and ndarray Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * fixes tests Signed-off-by: Wenqi Li <[email protected]> * try to use torch.solve Signed-off-by: Wenqi Li <[email protected]> * temp updates Signed-off-by: Wenqi Li <[email protected]> * enhance typing Signed-off-by: Wenqi Li <[email protected]> * temp test Signed-off-by: Wenqi Li <[email protected]> * fixes Signed-off-by: Wenqi Li <[email protected]> * Revert "temp test" This reverts commit 6200a38. Signed-off-by: Wenqi Li <[email protected]> * enhance types Signed-off-by: Wenqi Li <[email protected]> * update util Signed-off-by: Wenqi Li <[email protected]> * reverse workaround Signed-off-by: Wenqi Li <[email protected]> * formatting Signed-off-by: Wenqi Li <[email protected]> * update type def. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: Wenqi Li <[email protected]> * temp test Signed-off-by: Wenqi Li <[email protected]> * warn unused Signed-off-by: Wenqi Li <[email protected]> * remote ignore Signed-off-by: Wenqi Li <[email protected]> * Revert "warn unused" This reverts commit e645807. Signed-off-by: Wenqi Li <[email protected]> * Revert "temp test" This reverts commit ddc4770. Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: monai-bot <[email protected]>

* temp spatial_resample Signed-off-by: Wenqi Li <[email protected]> * fixes resampling Signed-off-by: Wenqi Li <[email protected]> * fixes precisions Signed-off-by: Wenqi Li <[email protected]> * update dict version Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * adds docs Signed-off-by: Wenqi Li <[email protected]> * copy grid for resampling Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * remove normalize coordinates Signed-off-by: Wenqi Li <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> * try to fix #3621 (#3673) Signed-off-by: Wenqi Li <[email protected]> * fixes typing Signed-off-by: Wenqi Li <[email protected]> * fixes grid_sample, interpolate URLs Signed-off-by: Wenqi Li <[email protected]> * simplify norm_coords Signed-off-by: Wenqi Li <[email protected]> * update docstring Signed-off-by: Wenqi Li <[email protected]> * update moveaxis Signed-off-by: Wenqi Li <[email protected]> * spatial sample tests Signed-off-by: Wenqi Li <[email protected]> * additional tests spatial resample Signed-off-by: Wenqi Li <[email protected]> * test invert saptial resample Signed-off-by: Wenqi Li <[email protected]> * adds a base writer and an itk writer Signed-off-by: Wenqi Li <[email protected]> * update docstrings Signed-off-by: Wenqi Li <[email protected]> * remove return self Signed-off-by: Wenqi Li <[email protected]> * adds reorient_spatial_axes Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * sync 3701 Signed-off-by: Wenqi Li <[email protected]> * try to fix #3766 Signed-off-by: Wenqi Li <[email protected]> * revise docstring to be concise Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * 3765 Enhance `create_multigpu_supervised_XXX` for distributed (#3768) * [DLMED] add check for devices Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> * update to support dynamic spatial_size Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>

* temp spatial_resample Signed-off-by: Wenqi Li <[email protected]> * fixes resampling Signed-off-by: Wenqi Li <[email protected]> * fixes precisions Signed-off-by: Wenqi Li <[email protected]> * update dict version Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * adds docs Signed-off-by: Wenqi Li <[email protected]> * copy grid for resampling Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * remove normalize coordinates Signed-off-by: Wenqi Li <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> * try to fix #3621 (#3673) Signed-off-by: Wenqi Li <[email protected]> * fixes typing Signed-off-by: Wenqi Li <[email protected]> * fixes grid_sample, interpolate URLs Signed-off-by: Wenqi Li <[email protected]> * simplify norm_coords Signed-off-by: Wenqi Li <[email protected]> * update docstring Signed-off-by: Wenqi Li <[email protected]> * update moveaxis Signed-off-by: Wenqi Li <[email protected]> * spatial sample tests Signed-off-by: Wenqi Li <[email protected]> * additional tests spatial resample Signed-off-by: Wenqi Li <[email protected]> * test invert saptial resample Signed-off-by: Wenqi Li <[email protected]> * adds a base writer and an itk writer Signed-off-by: Wenqi Li <[email protected]> * update docstrings Signed-off-by: Wenqi Li <[email protected]> * remove return self Signed-off-by: Wenqi Li <[email protected]> * adds reorient_spatial_axes Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]> * sync 3701 Signed-off-by: Wenqi Li <[email protected]> * try to fix #3766 Signed-off-by: Wenqi Li <[email protected]> * revise docstring to be concise Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * 3765 Enhance `create_multigpu_supervised_XXX` for distributed (#3768) * [DLMED] add check for devices Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> * update to support dynamic spatial_size Signed-off-by: Wenqi Li <[email protected]> * adds nibabel pil writers Signed-off-by: Wenqi Li <[email protected]> * remove unused ignore Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>

wyli added 6 commits January 18, 2022 11:52

try to fix Project-MONAI#3621

f5d8c18

Signed-off-by: Wenqi Li <[email protected]>

Merge branch 'dev' into 3621-adds-metrics-saver-barrier

c951b49

Merge branch 'dev' into 3621-adds-metrics-saver-barrier

c4c873c

Merge branch 'dev' into 3621-adds-metrics-saver-barrier

2953ed1

Merge branch 'dev' into 3621-adds-metrics-saver-barrier

1645fcb

Merge branch 'dev' into 3621-adds-metrics-saver-barrier

633ebb1

wyli marked this pull request as ready for review January 20, 2022 11:17

wyli requested a review from Nic-Ma January 20, 2022 11:17

wyli added 4 commits January 21, 2022 12:01

Merge branch 'dev' into 3621-adds-metrics-saver-barrier

d1118fd

Merge branch 'dev' into 3621-adds-metrics-saver-barrier

402576c

Merge branch 'dev' into 3621-adds-metrics-saver-barrier

011bf35

Merge branch 'dev' into 3621-adds-metrics-saver-barrier

65e2306

wyli enabled auto-merge (squash) January 24, 2022 14:55

Merge branch 'dev' into 3621-adds-metrics-saver-barrier

4a2dbaf

Nic-Ma approved these changes Jan 25, 2022

View reviewed changes

wyli merged commit 3180c27 into Project-MONAI:dev Jan 25, 2022

wyli added a commit to wyli/MONAI that referenced this pull request Jan 25, 2022

try to fix Project-MONAI#3621 (Project-MONAI#3673)

01e7f8d

Signed-off-by: Wenqi Li <[email protected]>

wyli added a commit to wyli/MONAI that referenced this pull request Jan 26, 2022

try to fix Project-MONAI#3621 (Project-MONAI#3673)

7b91be4

Signed-off-by: Wenqi Li <[email protected]>

wyli deleted the 3621-adds-metrics-saver-barrier branch April 27, 2022 22:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3621 fixes `tests/test_handler_metrics_saver_dist.py`#3673

3621 fixes `tests/test_handler_metrics_saver_dist.py`#3673
wyli merged 11 commits intoProject-MONAI:devfrom
wyli:3621-adds-metrics-saver-barrier

wyli commented Jan 18, 2022

Uh oh!

Nic-Ma commented Jan 20, 2022

Uh oh!

wyli commented Jan 24, 2022

Uh oh!

wyli commented Jan 25, 2022

Uh oh!

Nic-Ma left a comment

Uh oh!

wyli commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

wyli commented Jan 18, 2022

Description

Status

Types of changes

Uh oh!

Nic-Ma commented Jan 20, 2022

Uh oh!

wyli commented Jan 24, 2022

Uh oh!

wyli commented Jan 25, 2022

Uh oh!

Nic-Ma left a comment

Choose a reason for hiding this comment

Uh oh!

wyli commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants