Skip to content

DictPostFixes#3671

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
rijobro:meta_dict
Jan 18, 2022
Merged

DictPostFixes#3671
wyli merged 3 commits intoProject-MONAI:devfrom
rijobro:meta_dict

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Jan 17, 2022

Follows from #3605.

Description

Replace "meta_dict" with DictPostFixes.META.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Richard Brown <[email protected]>
@ericspod
Copy link
Copy Markdown
Member

We may want to commit #3605 first to prevent conflicts if git gets confused about two changes in very close proximity.

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is the first step towards https://github.com/Project-MONAI/MONAI/milestone/31. cc @Nic-Ma please let me know any concerns otherwise I'll merge it today...

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 18, 2022

/build

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks for the enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants