Skip to content

3661 Add default values to CopyItems transform#3662

Merged
Nic-Ma merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:3661-default-copyitem
Jan 14, 2022
Merged

3661 Add default values to CopyItems transform#3662
Nic-Ma merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:3661-default-copyitem

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jan 14, 2022

Fixes #3661 .

Description

This PR added default value of args in CopyItems transform to improve user experience according to @holgerroth 's feedback.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 14, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 14, 2022

/build

Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma Nic-Ma changed the title [WIP] 3661 Add default values to CopyItems transform 3661 Add default values to CopyItems transform Jan 14, 2022
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 14, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 14, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli January 14, 2022 10:33
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@Nic-Ma Nic-Ma enabled auto-merge (squash) January 14, 2022 10:57
@Nic-Ma Nic-Ma merged commit a644b40 into Project-MONAI:dev Jan 14, 2022
wyli pushed a commit that referenced this pull request Jan 14, 2022
* [DLMED] add default values

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix typo

Signed-off-by: Nic Ma <[email protected]>
wyli pushed a commit that referenced this pull request Jan 21, 2022
* [DLMED] add default values

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix typo

Signed-off-by: Nic Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default times of copyitems to 1

2 participants