Skip to content

3648 Enhance correct centers for crop#3652

Merged
Nic-Ma merged 10 commits intoProject-MONAI:devfrom
Nic-Ma:enhance-correct-centers
Jan 13, 2022
Merged

3648 Enhance correct centers for crop#3652
Nic-Ma merged 10 commits intoProject-MONAI:devfrom
Nic-Ma:enhance-correct-centers

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jan 13, 2022

Fixes #3648 .

Description

This PR optimized the logic of correct_centers to avoid tensor -> numpy conversion and use scalar values directly.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 13, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 13, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli January 13, 2022 03:34
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 13, 2022

/integration-test

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 13, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 13, 2022

/build

@Nic-Ma Nic-Ma merged commit f089659 into Project-MONAI:dev Jan 13, 2022
wyli pushed a commit that referenced this pull request Jan 14, 2022
* [DLMED] add missing doc-string

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] enhance correct centers

Signed-off-by: Nic Ma <[email protected]>
wyli pushed a commit that referenced this pull request Jan 21, 2022
* [DLMED] add missing doc-string

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] enhance correct centers

Signed-off-by: Nic Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants