removes duplicated docstring rendering#3651
Merged
wyli merged 4 commits intoProject-MONAI:devfrom Jan 13, 2022
Merged
Conversation
Signed-off-by: Wenqi Li <[email protected]>
wyli
changed the title
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
as our doc page defaults to the milestone releases, would be great to include this PR in 0.8.1 #3479 |
Nic-Ma
approved these changes
Jan 13, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Good finding! Thanks for the quick fix, looks good to me.
Is there any preview of the expected web page after building with this PR?
Thanks.
Contributor
Author
|
yes the preview of this PR is deployed here https://monai-dev.readthedocs.io/en/fixes-sphinx/data.html |
Contributor
Author
|
/build |
1 similar comment
Contributor
Author
|
/build |
Contributor
Author
|
/build |
wyli
added a commit
that referenced
this pull request
Jan 14, 2022
* removed duplicated Signed-off-by: Wenqi Li <[email protected]> * update gitignore to ignore readthedocs autobuild Signed-off-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Description
for example https://docs.monai.io/en/stable/data.html#iterabledataset
__init__arguments are rendered twice as the class docstring and__init__method docstring, this PR removes the duplicated onesStatus
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.