moveaxis with sequence of dims and typing enhancements#3648
Merged
wyli merged 2 commits intoProject-MONAI:devfrom Jan 13, 2022
Merged
moveaxis with sequence of dims and typing enhancements#3648wyli merged 2 commits intoProject-MONAI:devfrom
wyli merged 2 commits intoProject-MONAI:devfrom
Conversation
wyli
force-pushed
the
moveaxis-with-indices
branch
from
a33326d to
095a2fe
Compare
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
moveaxis-with-indices
branch
from
095a2fe to
4e474d8
Compare
wyli
commented
Jan 12, 2022
7 tasks
wyli
changed the title
Nic-Ma
approved these changes
Jan 13, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the enhancement for moveaxis.
Thanks.
7 tasks
Contributor
Author
|
/build |
wyli
added a commit
that referenced
this pull request
Jan 14, 2022
Signed-off-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Description
The pytorch/numpy APIs supports a sequence of ints as
moveaxisarguments,this PR enhances the
moveaxisinmonai/transforms/utils_pytorch_numpy_unification.pyso that it also accepts sequences.The PR also enhances the typing annotations
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.