Skip to content

3643 update meshgrid#3644

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:3643-meshgrid-ij
Jan 12, 2022
Merged

3643 update meshgrid#3644
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:3643-meshgrid-ij

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jan 11, 2022 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Fixes #3643

Description

meshgrid with the indexing option

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
update meshgrid
4914e24 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli marked this pull request as ready for review January 12, 2022 08:12
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jan 12, 2022

/build

Nic-Ma
Nic-Ma approved these changes Jan 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@ericspod Do you have any other comments?

Thanks in advance.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jan 12, 2022

/build

@wyli wyli enabled auto-merge (squash) January 12, 2022 10:54
@ericspod
Copy link
Copy Markdown
Member

ericspod commented Jan 12, 2022 •
edited
Loading

Looks good to me. This will reduce the number of warnings Pytorch brings up.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jan 12, 2022

/build

@wyli wyli merged commit d58e234 into Project-MONAI:dev Jan 12, 2022
@wyli wyli deleted the 3643-meshgrid-ij branch April 27, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warning using RandAffined. torch.meshgrid: pass the indexing argument

3 participants

@wyli @ericspod @Nic-Ma