Skip to content

3624 Add kwargs to torch APIs of utilities#3631

Merged
wyli merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:3624-add-kwargs
Jan 10, 2022
Merged

3624 Add kwargs to torch APIs of utilities#3631
wyli merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:3624-add-kwargs

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jan 10, 2022

Fixes #3624 .

Description

This PR added the kwargs to torch utilities as contiguous, and also added doc-strings.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 10, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 10, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli January 10, 2022 15:43
@wyli wyli mentioned this pull request Jan 10, 2022
7 tasks
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 10, 2022

/build

@wyli wyli enabled auto-merge (squash) January 10, 2022 17:41
@wyli wyli merged commit 2fef7ff into Project-MONAI:dev Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add kwargs to pytorch_numpy_unification

2 participants