Skip to content

3620 Fix dtype issue in ScaleIntensityRangePercentiles#3625

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:3620-update-scale-test
Jan 10, 2022
Merged

3620 Fix dtype issue in ScaleIntensityRangePercentiles#3625
wyli merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:3620-update-scale-test

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jan 10, 2022

Fixes #3620 .

Description

This PR fixed the dtype issue in ScaleIntensityRangePercentiles when channel wise.
Refer to: https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/intensity/array.py#L450.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 10, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 10, 2022

/build

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@Nic-Ma Nic-Ma changed the title [WIP] 3620 Fix dtype issue in ScaleIntensityRangePercentiles 3620 Fix dtype issue in ScaleIntensityRangePercentiles Jan 10, 2022
@Nic-Ma Nic-Ma marked this pull request as ready for review January 10, 2022 09:46
@wyli wyli merged commit 24404f4 into Project-MONAI:dev Jan 10, 2022
wyli pushed a commit that referenced this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_scale_intensity_range_percentiles error

2 participants