Merged
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
Nic-Ma
reviewed
Jan 9, 2022
Contributor
There was a problem hiding this comment.
Hi @wyli ,
Thanks for the quick fix, it overall looks good to me.
Please double confirm the case that: if some URL or URL args changed in the CI tests (not invalid URL with URLError), this PR may always skip the tests due to RuntimeError and doesn't report errors.
Maybe we can try to split the RuntimeError more clearly for not existing and denied permission in this PR to avoid the case and only skip denied permission?
https://github.com/Project-MONAI/MONAI/blob/dev/monai/apps/utils.py#L196
What do you think?
Thanks.
Signed-off-by: Wenqi Li <[email protected]>
Nic-Ma
approved these changes
Jan 9, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the quick update, looks good to me.
Contributor
Author
|
/build |
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
Jan 10, 2022
* 3616 test downloading issues Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* 3616 test downloading issues Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #3616
Description
adding a test util to
download_url_or_skip_testStatus
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.