SliceInferer for slice-by-slice infererence#3602
SliceInferer for slice-by-slice infererence#3602wyli merged 10 commits intoProject-MONAI:devfrom surajpaib:3458-slice-inferer
Conversation
|
Hi @Nic-Ma, this is the first version of incorporating the What do you think of the implementation? For now, it is the same as what was in the tutorials with better documentation. I'm trying to think of how to make it more readable and concise. Any inputs would be appreciated. |
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the quick implementation!
Put some minor comments inline.
And please add some unit tests to cover the logic.
Thanks.
Signed-off-by: Suraj Pai <[email protected]>
…3458-slice-inferer
|
Hi @Nic-Ma Incorporated all the changes you suggested and added a unit test. Let me know if something is missing. I also changed the logic a bit to make the purpose of the |
Nic-Ma
left a comment
There was a problem hiding this comment.
Hi @surajpaib ,
Really sorry for the late response, I missed this PR last week..
Looks good to me, put minor comments inline.
@wyli Could you please help double confirm it?
Thanks.
Signed-off-by: Suraj Pai <[email protected]>
|
Hi @surajpaib , There is some format error in the code according to CI tests: Thanks. |
Signed-off-by: Wenqi Li <[email protected]>
Fixes #3458
Description
Addition of SliceInferer to the monai.inferers for slice-by-slice inference on a 3D volume using a 2D model.
Status
Work in progress
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.