3600 Apply unused kwargs for 3rd party APIs in WSIReader#3601
Merged
Nic-Ma merged 11 commits intoProject-MONAI:devfrom Jan 7, 2022
Merged
3600 Apply unused kwargs for 3rd party APIs in WSIReader#3601Nic-Ma merged 11 commits intoProject-MONAI:devfrom
kwargs for 3rd party APIs in WSIReader#3601Nic-Ma merged 11 commits intoProject-MONAI:devfrom
Conversation
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Contributor
Author
|
/build |
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/build |
wyli
approved these changes
Jan 7, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
It seems openslide doesn't support additional arguments in the constructor, otherwise it looks good
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
Jan 10, 2022
…ONAI#3601) * [DLMED] add kwargs Signed-off-by: Nic Ma <[email protected]> * [DLMED] add unit test Signed-off-by: Nic Ma <[email protected]> * [DLMED] fix doc typo Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]>
wyli
pushed a commit
that referenced
this pull request
Jan 10, 2022
* [DLMED] add kwargs Signed-off-by: Nic Ma <[email protected]> * [DLMED] add unit test Signed-off-by: Nic Ma <[email protected]> * [DLMED] fix doc typo Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3600 .
Description
This PR applied the unused
kwargsarg inWSIReaderfor the additional args of 3rd party APIs, like:https://scikit-image.org/docs/0.14.x/api/skimage.external.tifffile.html#skimage.external.tifffile.TiffFile
https://openslide.org/api/python/#openslide.OpenSlide
https://github.com/rapidsai/cucim/blob/v21.12.00/cpp/include/cucim/cuimage.h#L100
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.