Skip to content

conda environment yaml file#3584

Merged
rijobro merged 2 commits intoProject-MONAI:devfrom
rijobro:conda-yml
Jan 7, 2022
Merged

conda environment yaml file#3584
rijobro merged 2 commits intoProject-MONAI:devfrom
rijobro:conda-yml

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Jan 5, 2022

Description

Conda environment yaml file. Combines requirements.txt, requirements-min.txt and requirements-dev.txt as nested calls aren't possible with conda.

Allows conda env create -f environment-dev.yml.

@wyli if you agree with this proposal, it would be great if it could be tested in some capacity by our CI/CD -- would you be able to take care of that?

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from Nic-Ma and wyli January 5, 2022 16:03
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 5, 2022

@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Jan 5, 2022

These are useful for installing MONAI from conda, but what if a user wants to git clone the repository and then use conda to install dependencies rather than pip?

@rijobro rijobro requested a review from ericspod January 5, 2022 18:31
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 5, 2022

I see, I'm also looking at the options here for sharing packages and environments:

(created an account https://anaconda.org/project-monai, in case we also release the environment file there.)

happy to set up the CI/CD to simulate the installation steps once we agree on the releasing approach @ericspod @Nic-Ma @IsaacYangSLA

@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Jan 6, 2022

And if we merge, we should add "Ensure pip and conda package dependencies match" to our release checklist.

@ericspod
Copy link
Copy Markdown
Member

ericspod commented Jan 7, 2022

This is really useful for creating environments quickly we know will be setup for development, we just have to be aware of different versions of packages being available through conda and pip. For example I've encountered issues in the past of differing behaviour between a conda version of black and the pip version. We can add a job to the CI/CD to just run the quick tests using a conda environment.

@mdraw
Copy link
Copy Markdown

mdraw commented Jan 7, 2022

Hi, I'm the creator and currently the sole maintainer of this feedstock/package on conda-forge. I just wanted to mention that I would appreciate if anyone from the MONAI dev team wanted to join as a maintainer on this conda-forge feedstock, because I'm just an occasional user of this library and can't guarantee to always keep everything up to date there.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 7, 2022

thanks, I've updated the release checklist to include a feedstock version review

@rijobro rijobro enabled auto-merge (squash) January 7, 2022 13:55
@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Jan 7, 2022

Great thanks for the reviews. If everyone is happy, could they approve this PR, I've enabled auto-merge.

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 7, 2022

/build

@rijobro rijobro merged commit a93b8cc into Project-MONAI:dev Jan 7, 2022
@rijobro rijobro deleted the conda-yml branch January 7, 2022 21:35
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants