Update CSVDataset in dataset.py#3529
Merged
wyli merged 4 commits intoProject-MONAI:devfrom Mar 1, 2022
Merged
Conversation
`kwargs` argument currently addresses merge operation. There is no way to change `kwargs` for `read_csv ()` call (e.g. to change delimiter from standard `,` to `\t`. Suggestion: Have `kwargs_read_csv` and `kwargs_merge` arguments to allow separate and finer user-control over both loading & merging mechanism.
wyli
reviewed
Dec 21, 2021
wyli
approved these changes
Mar 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes lack of control over
pd.read_csv()parameters, e.g. it is now possible to denote the file delimiter.Description
kwargsargument currently addresses merge operation. There is no way to changekwargsforread_csv ()call (e.g. to change delimiter from standard,to\t.Suggestion: Have
kwargs_read_csvandkwargs_mergearguments to allow separate and finer user-control over both loading & merging mechanism.Status
Ready for review
Types of changes