/black

/build

/black

/build

/black

/build

/build

Hi @wyli ,

Thanks for your review and feedback.
Sorry maybe I didn't describe the PR clearly enough, it doesn't conflict with the lazy instantiation idea, it's only the utility to build one component from the dictionary.
For the lazy instantiation idea, I think it's the logic of handling the whole config content, when it's really necessary to create an instance, it will call this utility to create it. I will implement something like ConfigResolver to handle the whole config for the step 3 of #3482 later when we discussed with more team guys.

Thanks.

/black

/build

/black

/build

Hi @wyli ,

Thanks for your review and feedback. Sorry maybe I didn't describe the PR clearly enough, it doesn't conflict with the lazy instantiation idea, it's only the utility to build one component from the dictionary. For the lazy instantiation idea, I think it's the logic of handling the whole config content, when it's really necessary to create an instance, it will call this utility to create it. I will implement something like ConfigResolver to handle the whole config for the step 3 of #3482 later when we discussed with more team guys.

Thanks.

Maybe there's a misunderstanding here, the lazy instantiation will work at the component level as well. Also, it'll be useful to have a complete prototype and then we divide it into smaller pieces and merge. That'll be an efficient way to roll out a major feature.

Hi @wyli ,
Thanks for your review and feedback. Sorry maybe I didn't describe the PR clearly enough, it doesn't conflict with the lazy instantiation idea, it's only the utility to build one component from the dictionary. For the lazy instantiation idea, I think it's the logic of handling the whole config content, when it's really necessary to create an instance, it will call this utility to create it. I will implement something like ConfigResolver to handle the whole config for the step 3 of #3482 later when we discussed with more team guys.
Thanks.

Maybe there's a misunderstanding here, the lazy instantiation will work at the component level as well. Also, it'll be useful to have a complete prototype and then we divide it into smaller pieces and merge. That'll be an efficient way to roll out a major feature.

OK, sounds good to me.
Let's try to discuss and align with team members on the first step of #3482 (the MVP model package draft structure: Project-MONAI/tutorials#487), then I will develop a complete prototype in a separate branch.

Thanks.