Skip to content

[poc] 2620 - image writer#3443

Closed
wyli wants to merge 4 commits intodevfrom
feature/2620-image-writer
Closed

[poc] 2620 - image writer#3443
wyli wants to merge 4 commits intodevfrom
feature/2620-image-writer

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Dec 3, 2021

Signed-off-by: Wenqi Li [email protected]

part of #2620 #3595

Description

ongoing discussions about the image writer module

Status

on hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli force-pushed the feature/2620-image-writer branch 2 times, most recently from c68705a to 78e182c Compare December 10, 2021 11:05
@wyli wyli force-pushed the feature/2620-image-writer branch from 78e182c to c558664 Compare December 20, 2021 15:31
@wyli wyli force-pushed the feature/2620-image-writer branch 11 times, most recently from 0ed96aa to 3206fa6 Compare January 12, 2022 17:37
@wyli wyli marked this pull request as ready for review January 12, 2022 17:38
@wyli wyli requested review from Nic-Ma, ericspod and rijobro January 12, 2022 17:38
@wyli wyli force-pushed the feature/2620-image-writer branch from ec6a02f to 64550af Compare January 14, 2022 14:43
wyli added 3 commits January 14, 2022 17:30
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the feature/2620-image-writer branch from 64550af to d5cf137 Compare January 14, 2022 17:49
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Feb 8, 2022

comments are addressed by multiple PRs, this becomes out-of-date, please see #3595

@wyli wyli closed this Feb 8, 2022
@wyli wyli deleted the feature/2620-image-writer branch February 8, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants