Skip to content

3192 adds plot util#3193

Merged
wyli merged 17 commits intoProject-MONAI:devfrom
wyli:adds-vis
Nov 1, 2021
Merged

3192 adds plot util#3193
wyli merged 17 commits intoProject-MONAI:devfrom
wyli:adds-vis

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Oct 26, 2021 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Fixes #3192

Description

Figure_1
Figure_2

Status

ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 5 commits October 28, 2021 21:40
@wyli
adds plot util
833f272 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update fig
e7226f6 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes mypy issues
511f962 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes type convertion
ff92b14 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes dtypes
d8b0902 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 30, 2021

/build

wyli added 2 commits October 30, 2021 22:36
@wyli
set seeds for cropping
9a754c4 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
extra checks
c075f39 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 30, 2021

/build

1 similar comment
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 30, 2021

/build

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 30, 2021

/build

@wyli
adds matplotlib
3b6094f 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 30, 2021

/build

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 31, 2021

/build

@wyli wyli marked this pull request as ready for review October 31, 2021 09:42
@wyli
fixes typos
4486ebf 
Signed-off-by: Wenqi Li <[email protected]>
wyli
wyli commented Oct 31, 2021
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 31, 2021

/build

ericspod
ericspod reviewed Oct 31, 2021
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 31, 2021

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Oct 31, 2021

Hi @ericspod and @wyli ,

Thanks for the great PR, please wait a while before merging it.
I will try to review it tonight.

Thanks.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Nov 1, 2021

/build

1 similar comment
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Nov 1, 2021

/build

Nic-Ma
Nic-Ma approved these changes Nov 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some minor comments inline.
Others look good to me.

Thanks.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Nov 1, 2021

/build

@wyli wyli enabled auto-merge (squash) November 1, 2021 12:33
@wyli wyli merged commit 3339f43 into Project-MONAI:dev Nov 1, 2021
@wyli wyli deleted the adds-vis branch November 16, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

util to visualise 3d volumes

3 participants

@wyli @Nic-Ma @ericspod