Skip to content

Add tutorial link to doc-string of handlers#3150

Merged
Nic-Ma merged 9 commits intoProject-MONAI:devfrom
Nic-Ma:add-handler-example-link
Oct 20, 2021
Merged

Add tutorial link to doc-string of handlers#3150
Nic-Ma merged 9 commits intoProject-MONAI:devfrom
Nic-Ma:add-handler-example-link

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Oct 20, 2021 •
edited
Loading

Description

This PR added the usage example tutorial link to the doc-string of several handlers.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 20, 2021

Mark WIP as it depends on: Project-MONAI/tutorials#408.

Thanks.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 20, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 20, 2021

/build

@Nic-Ma Nic-Ma changed the title [WIP] Add tutorial link to doc-string of handlers Add tutorial link to doc-string of handlers Oct 20, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review October 20, 2021 05:00
@Nic-Ma
[DLMED] fix typo
28919b0 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma Nic-Ma enabled auto-merge (squash) October 20, 2021 05:09
@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

yiheng-wang-nv commented Oct 20, 2021

Thanks Nic, could you please also help to add the link of dynunet pipeline into class DynUNet?
As this discussion mentioned (#3149)

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 20, 2021

Thanks Nic, could you please also help to add the link of dynunet pipeline into class DynUNet? As this discussion mentioned (#3149)

Sure, added the tutorial link in the latest commit.
Thanks.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 20, 2021

/build

1 similar comment
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 20, 2021

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 20, 2021 •
edited
Loading

Hi @wyli ,

I got a question about the blossom test here: it failed, but when I click the "Details", the status is success, may I know why?

Thanks in advance.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 20, 2021

/build

@Nic-Ma Nic-Ma merged commit 4785ede into Project-MONAI:dev Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@wyli wyli Awaiting requested review from wyli

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nic-Ma @yiheng-wang-nv