Skip to content

senet tests with monai's testing data#3136

Merged
wyli merged 1 commit intoProject-MONAI:devfrom
wyli:speedup-tests
Oct 15, 2021
Merged

senet tests with monai's testing data#3136
wyli merged 1 commit intoProject-MONAI:devfrom
wyli:speedup-tests

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Oct 15, 2021

Signed-off-by: Wenqi Li [email protected]

The SENet pretrained model tests are not stable due the weight downloading,
this PR modifies the unit tests to use monai's host of testing data.

"senet154": "http://data.lip6.fr/cadene/pretrainedmodels/senet154-c7b49a05.pth",
"se_resnet50": "http://data.lip6.fr/cadene/pretrainedmodels/se_resnet50-ce0d4300.pth",

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli added this to the Bug Fixes or Misc improvements milestone Oct 15, 2021
@wyli wyli changed the title senet tests with testing data senet tests with monai's testing data Oct 15, 2021
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 15, 2021

/build

@wyli wyli marked this pull request as ready for review October 15, 2021 14:39
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 15, 2021

the downloading command was the bottleneck, this can sometimes reduce the premerge pipeline time from ~48min to ~30min

@wyli wyli merged commit 1259042 into Project-MONAI:dev Oct 15, 2021
@wyli wyli deleted the speedup-tests branch October 15, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants