Skip to content

3124 3126 Fix integration tests#3130

Merged
wyli merged 12 commits intoProject-MONAI:devfrom
Nic-Ma:3118-track-state
Oct 14, 2021
Merged

3124 3126 Fix integration tests#3130
wyli merged 12 commits intoProject-MONAI:devfrom
Nic-Ma:3118-track-state

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Oct 14, 2021 •
edited by wyli
Loading

Fixes #3124
fixes #3126 .

Description

This PR fixed the integration tests and updated the random state of some transforms.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 14, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 14, 2021

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 14, 2021

/integration-test

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 14, 2021 15:58
@Nic-Ma Nic-Ma mentioned this pull request Oct 14, 2021
Closed
@Nic-Ma Nic-Ma changed the title 3126 Fix integration tests 3124 3126 Fix integration tests Oct 14, 2021
monai-bot and others added 2 commits October 14, 2021 16:01
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Oct 14, 2021

/build

wyli
wyli approved these changes Oct 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me. it passes the integration tests https://github.com/Project-MONAI/MONAI/actions/runs/1342568887

@wyli wyli merged commit cd6e90c into Project-MONAI:dev Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

integration test errors There are 2 kinds of random state in transforms

4 participants

@Nic-Ma @wyli @ericspod @monai-bot