allow ROIs bigger than image for RandCropByPosNegLabel and RandCropByLabelClasses#3129
Merged
wyli merged 2 commits intoProject-MONAI:devfrom Oct 15, 2021
Merged
Conversation
…gLabel Signed-off-by: Richard Brown <[email protected]>
Contributor
|
/build |
wyli
approved these changes
Oct 15, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, this is a non-breaking usability improvement, looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if an image is already bigger than the requested padded ROI, by default we leave the image unchanged in that dimension.
Conversely, if an image is smaller than the requested ROI for
RandCropByPosNegLabelandRandCropByLabelClasses, we throw an error. This is inconvenient for datasets of inhomogeneous shapes. For example, I might say "if an image is bigger than (100,100,100), then crop to this size. If it's smaller, then leave it as-is".Currently, this is not possible in MONAI, so this PR adds
allow_smaller. IfTrue, any dimension smaller than the requested crop size won't be cropped, instead of raising an exception.Default is set to
Falseto keep backwards compatibility.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.