Skip to content

3118 Add support to track state attributes in handlers#3125

Merged
Nic-Ma merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:3118-track-state
Oct 14, 2021
Merged

3118 Add support to track state attributes in handlers#3125
Nic-Ma merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:3118-track-state

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Oct 14, 2021

Fixes #3118 .

Description

This PR added support to track engine.state attributes in handlers, referring to ignite internal handlers:
https://github.com/pytorch/ignite/blob/master/ignite/contrib/handlers/base_logger.py#L55

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 14, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 14, 2021

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 14, 2021 04:43
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Oct 14, 2021

/build

@Nic-Ma Nic-Ma merged commit 356af91 into Project-MONAI:dev Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to track engine.state.XXX in handlers

3 participants