Skip to content

3087 Enhance other RandomizableTransform transforms#3113

Merged
wyli merged 12 commits intoProject-MONAI:devfrom
Nic-Ma:3087-enhance-other-transforms
Oct 13, 2021
Merged

3087 Enhance other RandomizableTransform transforms#3113
wyli merged 12 commits intoProject-MONAI:devfrom
Nic-Ma:3087-enhance-other-transforms

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Oct 12, 2021

Fixes #3087 .

Description

Follow up of #3094 , this PR updated all the other RandomizableTransform transforms.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 12, 2021 11:44
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 12, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 12, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 12, 2021

/build

@Nic-Ma Nic-Ma requested a review from rijobro October 13, 2021 14:11
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce code duplication -- Random dictionary transforms that can't call their array version

3 participants