Skip to content

2721 - enhance transform figures#3083

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:fixes-ylabels
Oct 8, 2021
Merged

2721 - enhance transform figures#3083
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:fixes-ylabels

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Oct 8, 2021

Signed-off-by: Wenqi Li [email protected]

part of #2721

Description

  • adds a rough estimation for the height ratios when comparing before/after
  • adds a few labels for the right-most col if there's no colorbar

RandSpatialCropSamples
CenterSpatialCropd

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
fixes figures
404f93b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma, ericspod and rijobro October 8, 2021 09:25
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 8, 2021

couldn't make the size of subplot panels to be exactly proportional to the actual image sizes @rijobro, so I put some yticks here and I guess they are helpful.

@wyli wyli changed the title enhance transform figures 2721 - enhance transform figures Oct 8, 2021
@wyli wyli mentioned this pull request Oct 8, 2021
Merged
rijobro
rijobro approved these changes Oct 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! You'll need to commit the updated images to the DocImages repository of course.

For the DocImages repository, I'm thinking about keeping the history flat from the most recent release to reduce the size of the git history. So I've been amending to the previous commit and force-pushing over the top. What do you think?

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 8, 2021

Looks great, thanks! You'll need to commit the updated images to the DocImages repository of course.

For the DocImages repository, I'm thinking about keeping the history flat from the most recent release to reduce the size of the git history. So I've been amending to the previous commit and force-pushing over the top. What do you think?

sounds good, Iet me do the same for this update.

@wyli wyli merged commit 6169c5d into Project-MONAI:dev Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rijobro rijobro rijobro approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wyli @rijobro