Skip to content

Enhance version_leq API and doc-string#3080

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:enhance-version-leq
Oct 7, 2021
Merged

Enhance version_leq API and doc-string#3080
wyli merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:enhance-version-leq

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Oct 7, 2021

Description

This PR enhanced the version_leq API to clearly define the input data type and doc-string.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 7, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 7, 2021 14:50
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli merged commit 8d07aad into Project-MONAI:dev Oct 7, 2021
@wyli wyli added this to the Backward compatibility [P0] milestone Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants