Skip to content

3063 Fix the complex Tensor issue in type conversion#3064

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:3063-fix-np-convert
Oct 4, 2021
Merged

3063 Fix the complex Tensor issue in type conversion#3064
wyli merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:3063-fix-np-convert

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Oct 4, 2021

Fixes #3063 .

Description

This PR fixed the issue that PyTorch 1.5.1 can't support complex Tensor.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 4, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 4, 2021

Tested this PR in PyTorch 1.5.1:

root@apt-sh-ai:/workspace/data/medical/MONAI# python
Python 3.8.10 | packaged by conda-forge | (default, May 11 2021, 07:01:05)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> print(torch.__version__)
1.5.1
>>> exit()
root@apt-sh-ai:/workspace/data/medical/MONAI# python tests/test_k_space_spike_noised.py
..................
----------------------------------------------------------------------
Ran 18 tests in 3.938s

OK

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 4, 2021 10:47
@Nic-Ma Nic-Ma mentioned this pull request Oct 4, 2021
Closed
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Oct 4, 2021

/black

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Oct 4, 2021

/build

wyli
wyli approved these changes Oct 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli merged commit 7ad0f6e into Project-MONAI:dev Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error from convert_to_tensor

2 participants

@Nic-Ma @wyli