Skip to content

feat: refactor seg-net for easier use#3057

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
BenTenmann:refactor/segresnet
Oct 14, 2021
Merged

feat: refactor seg-net for easier use#3057
wyli merged 4 commits intoProject-MONAI:devfrom
BenTenmann:refactor/segresnet

Conversation

@BenTenmann
Copy link
Copy Markdown
Contributor

Fixes # seg-res-net refactor

Description

Refactored SegResNet forward method to separate encoder and decoder stacks to make it easier to implement the encoder in other architectures

Status

Work in progress

Types of changes

  • [] Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Oct 14, 2021

/black

Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Oct 14, 2021

/build

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a non-breaking change that makes segresnet's intermediate features available.

@wyli wyli enabled auto-merge (squash) October 14, 2021 11:45
@wyli wyli added this to the Bug Fixes or Misc improvements milestone Oct 14, 2021
@wyli wyli merged commit ed9cd41 into Project-MONAI:dev Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants