Skip to content

Torch Spacing, Spacingd#3045

Merged
rijobro merged 5 commits intoProject-MONAI:devfrom
rijobro:torch_Spacing
Sep 29, 2021
Merged

Torch Spacing, Spacingd#3045
rijobro merged 5 commits intoProject-MONAI:devfrom
rijobro:torch_Spacing

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Sep 29, 2021

Description

Torch Spacing, Spacingd

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from Nic-Ma and wyli September 29, 2021 11:31
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, for this one and the orientation transform, we should test it with the image writing functions as well https://github.com/Project-MONAI/MONAI/blob/dev/tests/test_nifti_rw.py#L102-L110

@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Sep 29, 2021

I updated test_nifti_rw.py to use torch and torch.cuda as input arrays. Is that what you meant?

@rijobro rijobro enabled auto-merge (squash) September 29, 2021 15:06
@rijobro rijobro merged commit bf561bb into Project-MONAI:dev Sep 29, 2021
@rijobro rijobro deleted the torch_Spacing branch September 30, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants