Skip to content

3028 update ignite CI tests to 0.4.6#3029

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:3028-update-ignite
Sep 27, 2021
Merged

3028 update ignite CI tests to 0.4.6#3029
wyli merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:3028-update-ignite

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Sep 27, 2021 •
edited
Loading

Fixes #3028 .

Description

This PR updated the ignite CI dependency to 0.4.6.
And we don't change the minimum dependency version in the code as no need to work with the latest ignite.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Sep 27, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Sep 27, 2021

/integration-test

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 27, 2021

Fixes #3028 .

Description

This PR updated the ignite CI dependency to 0.4.6 as @vfdev-5 released it last week.
And we don't change the minimum dependency version in the code as no need to work with the latest ignite.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Fixes #3028 .

Description

This PR updated the ignite CI dependency to 0.4.6 as @vfdev-5 released it last week.
And we don't change the minimum dependency version in the code as no need to work with the latest ignite.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Hi Nic, the PR description is unclear to me

  • Are you sure 0.4.6 was released in the last week?
  • The description says that we don't change the min version but in the code the version number had an updated?

@wyli wyli closed this Sep 27, 2021
@Nic-Ma Nic-Ma reopened this Sep 27, 2021
@Nic-Ma Nic-Ma changed the title 3028 update ignite CI tests to 0.4.6 [WIP] 3028 update ignite CI tests to 0.4.6 Sep 27, 2021
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Sep 27, 2021

Hi @wyli ,

Sorry I didn't notify the CI failure, will add you guys to review when I resolved the error.
And BTW, this PR follows the same logic we did for ignite v0.4.5 update, we only update CI environment and pip install to test with latest ignite, the min_version in the code is still 0.4.4: #2451

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 27, 2021

Hi @wyli ,

Sorry I didn't notify the CI failure, will add you guys to review when I resolved the error.
And BTW, this PR follows the same logic we did for ignite v0.4.5 update, we only update CI environment and pip install to test with latest ignite, the min_version in the code is still 0.4.4: #2451

Thanks.

Sure thanks for the clarification!

vfdev-5
vfdev-5 approved these changes Sep 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Nic-Ma !

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Sep 27, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Sep 27, 2021

/integration-test

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli September 27, 2021 17:03
@Nic-Ma Nic-Ma changed the title [WIP] 3028 update ignite CI tests to 0.4.6 3028 update ignite CI tests to 0.4.6 Sep 27, 2021
wyli
wyli approved these changes Sep 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli enabled auto-merge (squash) September 27, 2021 17:05
@wyli wyli merged commit fe93596 into Project-MONAI:dev Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@vfdev-5 vfdev-5 vfdev-5 approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to ignite 0.4.6

3 participants

@Nic-Ma @wyli @vfdev-5