Skip to content

remove redundant noqa#3027

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
Borda:yesqa
Oct 3, 2021
Merged

remove redundant noqa#3027
wyli merged 6 commits intoProject-MONAI:devfrom
Borda:yesqa

Conversation

@Borda
Copy link
Copy Markdown
Contributor

@Borda Borda commented Sep 24, 2021

Description

enable hook which is removing noqa notations which are not needed anymore

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Borda Borda marked this pull request as draft September 24, 2021 22:50
@Borda Borda force-pushed the yesqa branch 3 times, most recently from 4c068a8 to 688c106 Compare September 30, 2021 16:09
@Borda Borda marked this pull request as ready for review September 30, 2021 17:10
Signed-off-by: Jirka <[email protected]>
Signed-off-by: Jirka <[email protected]>
Signed-off-by: Jirka <[email protected]>
Signed-off-by: Jirka <[email protected]>
@Borda
Copy link
Copy Markdown
Contributor Author

Borda commented Oct 3, 2021

@wyli mind have look?

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it looks good to me.

@wyli wyli merged commit 8271d8e into Project-MONAI:dev Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants